[FIRRTL] AdvancedLayerSink: don't sink instances of mods with port annos #7982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
force-pushed
the
fix-advanced-layer-sink
branch
from
cbfb5a2 to
1a4a875
Compare
… annos If a module-like has port annotations, mark it as containing an effect, which will prevent the pass from moving or deleting its instances later on.
rwy7
force-pushed
the
fix-advanced-layer-sink
branch
from
65e1b7d to
9f3752b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module-like has port annotations, mark it as an effectful module, which will prevent the pass from moving or deleting its instances later on. We can't sink instance when we don't understand what port annotations mean.